Itamar Heim has posted comments on this change. Change subject: core: Initial support for alternative architectures ......................................................................
Patch Set 1: (5 inline comments) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/ArchRepository.java Line 10: HashMap<String, ArchitectureData> getArchitectures(); Line 11: Line 12: List<String> getArchitectureNames(); Line 13: Line 14: List<String> getDiskInterfaces(String architectureName, Version version); same - do we need this per arch, when we can limit this by OS per arch? Line 15: Line 16: boolean isDiskHotPluggingSupported(String architectureName, Version version); Line 17: Line 18: int getDefaultOs(String architectureName); Line 12: List<String> getArchitectureNames(); Line 13: Line 14: List<String> getDiskInterfaces(String architectureName, Version version); Line 15: Line 16: boolean isDiskHotPluggingSupported(String architectureName, Version version); do we need this per arch if we don't really share os's between arch's? Line 17: Line 18: int getDefaultOs(String architectureName); .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java Line 74: Line 75: /** Line 76: * @return returns a map that associates each OS to a boolean indicating if it could be connected with SPICE Line 77: */ Line 78: public HashMap<Version, HashMap<Integer, Boolean>> getSpiceSupportMap(); is spice not supported for ppc7 arch? (since regardless of guest os support, spice has basic console support) Line 79: Line 80: /** Line 81: * this is Windows OSs specific path to the sysprep file Line 82: * @param osId .................................................... File packaging/conf/archinfo-defaults.properties Line 1: arch.x86_64.devices.diskInterfaces.value = ide, virtio Line 2: arch.x86_64.devices.diskInterfaces.value.version.3.3 = ide, scsi, virtio Line 3: arch.x86_64.devices.diskHotPluggingSupported.value = true Line 4: arch.x86_64.defaultOs.value = 1000 i was thinking this may not be needed, if you can just define the 'default os' for ppc arch with these, then inherit other ppc OSs from it instead? Line 5: Line 6: arch.ppc64.devices.diskInterfaces.value.version.3.3 = virtio Line 7: arch.ppc64.devices.diskHotPluggingSupported.value.version.3.3 = false Line 8: arch.ppc64.defaultOs.value = 1001 Line 4: arch.x86_64.defaultOs.value = 1000 Line 5: Line 6: arch.ppc64.devices.diskInterfaces.value.version.3.3 = virtio Line 7: arch.ppc64.devices.diskHotPluggingSupported.value.version.3.3 = false Line 8: arch.ppc64.defaultOs.value = 1001 if using magic numbers, a comment with name at least please. -- To view, visit http://gerrit.ovirt.org/16700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33ed9231a6467aa59e8f3223ba9d61b6e68039fa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
