Allon Mureinik has posted comments on this change.

Change subject: core: Remove object_column_white_list from fixtures.xml
......................................................................


Patch Set 1:

@Yair:
This patch includes changing an upgrade script that effects the production 
system - changing sshFingerPrint to sshfingerprint.

If the whitelist is case sensitive - it means that without the patch the 
PRODUCTION code does not work properly, and you cannot display sshfingerprint 
to unprivileged users.
It is much more important than not breaking VdsDAOTest.

If the whitelist is NOT case sensitive - this change is a nicity, and 
VdsDAOTest is probably over restrictive.

-- 
To view, visit http://gerrit.ovirt.org/16703
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f0429c322f923f0b3c725270aa51c121ca27129
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to