Eli Mesika has posted comments on this change.

Change subject: core: Remove object_column_white_list from fixtures.xml
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql
Line 30:    -----------------------------------
Line 31:    -- Initial white list settings  ---
Line 32:    -----------------------------------
Line 33:    --            vds view
Line 34:    -----------------------------------
Seems that this change in not related to the patch , can you remove this file 
from commit please ?
Line 35:    --  A new added column will not be displayed for the user unless 
added specifically.
Line 36:       insert into object_column_white_list(object_name,column_name)
Line 37:       (select 'vds', column_name
Line 38:        from information_schema.columns


-- 
To view, visit http://gerrit.ovirt.org/16703
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f0429c322f923f0b3c725270aa51c121ca27129
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to