Allon Mureinik has posted comments on this change.
Change subject: frontend: add the import glance image support
......................................................................
Patch Set 5: (3 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java
Line 183: @Override
Line 184: public void executeCommand(UICommand command) {
Line 185: super.executeCommand(command);
Line 186:
Line 187: if (command == getImportImagesCommand()) {
are you sure that == (as opposed to equals) is OK here?
Line 188: importImages();
Line 189: }
Line 190: else if (command.getName().equals("Cancel")) { //$NON-NLS-1$
Line 191: cancel();
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/ImportExportImagePopupView.java
Line 106: public String getText(Object image) {
Line 107: if (image instanceof RepoImage) {
Line 108: return ((RepoImage) image).getRepoImageTitle();
Line 109: }
Line 110: return "(Unknown)"; //$NON-NLS-1$
shouldn't this be localized?
Line 111: }
Line 112: }, constants.fileNameIso());
Line 113: imageList.addEntityModelColumn(new
EntityModelTextColumn<Object>() {
Line 114: @Override
Line 115: public String getText(Object image) {
Line 116: if (image instanceof RepoImage) {
Line 117: return ((RepoImage)
image).getFileType().toString();
Line 118: }
Line 119: return "(Unknown)"; //$NON-NLS-1$
shouldn't this be localized?
Line 120: }
Line 121: }, constants.typeIso());
Line 122: imageList.addEntityModelColumn(new
DiskSizeColumn<EntityModel>() {
Line 123: @Override
--
To view, visit http://gerrit.ovirt.org/16083
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I084dadfd208255738140f093ffc8ec136f83d7f6
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
