Daniel Erez has posted comments on this change.
Change subject: frontend: add the import glance image support
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportExportRepoImageModel.java
Line 146:
Line 147: protected void updateControlsAvailability() {
Line 148: getDataCenter().setIsChangable(!getDataCenter().getIsEmpty());
Line 149:
getStorageDomain().setIsChangable(!getStorageDomain().getIsEmpty());
Line 150: getQuota().setIsChangable(!getQuota().getIsEmpty());
I agree, we usually don't disable empty list boxes...
Line 151:
getOkCommand().setIsExecutionAllowed(!getStorageDomain().getIsEmpty());
Line 152: setMessage(getStorageDomain().getIsEmpty() ?
constants.noStorageDomainAvailableMsg() : null);
Line 153: }
Line 154:
--
To view, visit http://gerrit.ovirt.org/16083
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I084dadfd208255738140f093ffc8ec136f83d7f6
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
