Doron Fediuck has posted comments on this change.
Change subject: webadmin: Add Ballooning to UI
......................................................................
Patch Set 5: (2 inline comments)
Minor rephrasing. Please update.
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 135:
Line 136: @DefaultStringValue("Enable Trusted Service")
Line 137: String clusterPolicyEnableTrustedServiceLabel();
Line 138:
Line 139: @DefaultStringValue("Enable Ballooning")
Please rephrase to: 'Enable Memory Balloon Optimization'.
Line 140: String enableBallooningLabel();
Line 141:
Line 142: @DefaultStringValue("Ballooning")
Line 143: String ballooningLabelTitle();
Line 138:
Line 139: @DefaultStringValue("Enable Ballooning")
Line 140: String enableBallooningLabel();
Line 141:
Line 142: @DefaultStringValue("Ballooning")
Please rephrase to: 'Memory Balloon'
Line 143: String ballooningLabelTitle();
Line 144:
Line 145: @DefaultStringValue("VM network")
Line 146: String clusterNewNetworkPopupVmNetworkLabel();
--
To view, visit http://gerrit.ovirt.org/16737
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d8f0701f64a1ebf76965cfcbdec2912158c0c90
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
