ofri masad has posted comments on this change.
Change subject: webadmin: Add Ballooning to UI
......................................................................
Patch Set 7: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
Line 1040:
Line 1041: // CPU Thread support is only available for clusters of
version 3.2 or greater
Line 1042:
getVersionSupportsCpuThreads().setEntity(version.compareTo(Version.v3_2) >= 0);
Line 1043:
getEnableBallooning().setChangeProhibitionReason(ConstantsManager.getInstance().getConstants().ballooningNotAvailable());
Line 1044:
getEnableBallooning().setIsChangable(version.compareTo(Version.v3_3) >= 0);
When the model is loaded it is loaded with version 3.1 until the data is
retrieved from DB. and so, in update dialog the value of Ballooning is lost.
we check for version on the listModel before saving the value.
Line 1045: }
Line 1046:
Line 1047: private void initCPU()
Line 1048: {
--
To view, visit http://gerrit.ovirt.org/16737
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d8f0701f64a1ebf76965cfcbdec2912158c0c90
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
