Allon Mureinik has posted comments on this change.
Change subject: frontend: add the export glance image support
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java
Line 597:
Line 598: private boolean isExportCommandAvailable() {
Line 599: ArrayList<Disk> disks = (ArrayList<Disk>) getSelectedItems();
Line 600:
Line 601: if (disks == null || disks.size() < 1) {
why not use disks.isEmpty()?
Line 602: return false;
Line 603: }
Line 604:
Line 605: for (Disk disk : disks)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/ImportExportImagePopupView.java
Line 118: public String getText(Object image) {
Line 119: if (image instanceof RepoImage) {
Line 120: return ((RepoImage)
image).getFileType().toString();
Line 121: } else if (image instanceof DiskImage) {
Line 122: return "Disk"; //$NON-NLS-1$
presumably this needs to be localized too?
Line 123: }
Line 124: return "(Unknown)"; //$NON-NLS-1$
Line 125: }
Line 126: }, constants.typeIso());
--
To view, visit http://gerrit.ovirt.org/16420
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ec1bd1de705233c3a0baf26e5f2a4c0a21645a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
