Tal Nisan has posted comments on this change.
Change subject: frontend: add the export glance image support
......................................................................
Patch Set 3: Looks good to me, approved
(1 inline comment)
Looks good, please fix the comments by others
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java
Line 597:
Line 598: private boolean isExportCommandAvailable() {
Line 599: ArrayList<Disk> disks = (ArrayList<Disk>) getSelectedItems();
Line 600:
Line 601: if (disks == null || disks.size() < 1) {
Hehe and if not using isEmpty, why use < 1 and not == 0? ;)
Line 602: return false;
Line 603: }
Line 604:
Line 605: for (Disk disk : disks)
--
To view, visit http://gerrit.ovirt.org/16420
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ec1bd1de705233c3a0baf26e5f2a4c0a21645a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
