Roy Golan has posted comments on this change.
Change subject: engine : VdsUpdateRuntimeInfo updates the data of a specific
VDS.
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(1 inline comment)
the comment is not about the solution but the use of paramsource
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java
Line 179: updateAllInBatch("updatevmdynamic", vmDynamicToSave.values(),
new MapSqlParameterMapper<VmDynamic>() {
Line 180: @Override
Line 181: public MapSqlParameterSource map(VmDynamic entity) {
Line 182: MapSqlParameterSource paramValue = new
MapSqlParameterSource();
Line 183:
may seem minor but please use the fluent api of params to inline all value
additions
patamValue.addValue(val)
.addValue(val2)
.addValue...
this means lass 30 something method invocations per each cycle
Line 184: paramValue.addValue("guest_cur_user_name",
entity.getGuestCurrentUserName());
Line 185: paramValue.addValue("console_cur_user_name",
entity.getConsoleCurrentUserName());
Line 186: paramValue.addValue("guest_last_login_time",
entity.getGuestLastLoginTime());
Line 187: paramValue.addValue("guest_last_logout_time",
entity.getGuestLastLogoutTime());
--
To view, visit http://gerrit.ovirt.org/16066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3e9735f4174ebabbe293d397d931aba72bbbd7b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
