Roy Golan has posted comments on this change.

Change subject: engine : VdsUpdateRuntimeInfo updates the data of a specific 
VDS.
......................................................................


Patch Set 7: (3 inline comments)

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java
Line 86:         updateAllInBatch("Updatevds_interface", dbIfacesToBatch, new 
MapSqlParameterMapper<VdsNetworkInterface>() {
Line 87:             @Override
Line 88:             public MapSqlParameterSource map(VdsNetworkInterface 
entity) {
Line 89:                 MapSqlParameterSource paramValue = new 
MapSqlParameterSource();
Line 90: 
same
Line 91:                 paramValue.addValue("addr", entity.getAddress());
Line 92:                 paramValue.addValue("bond_name", entity.getBondName());
Line 93:                 paramValue.addValue("bond_type", entity.getBondType());
Line 94:                 paramValue.addValue("gateway", entity.getGateway());


....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkStatisticsDaoDbFacadeImpl.java
Line 68: 
Line 69:                     @Override
Line 70:                     public MapSqlParameterSource 
map(VmNetworkStatistics entity) {
Line 71:                         MapSqlParameterSource paramValue = new 
MapSqlParameterSource();
Line 72:                         paramValue.addValue("id", entity.getId());
oh yeh
Line 73:                         paramValue.addValue("rx_drop", 
entity.getReceiveDropRate());
Line 74:                         paramValue.addValue("rx_rate", 
entity.getReceiveRate());
Line 75:                         paramValue.addValue("tx_drop", 
entity.getTransmitDropRate());
Line 76:                         paramValue.addValue("tx_rate", 
entity.getTransmitRate());


....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStatisticsDaoDbFacadeImpl.java
Line 78:                     @Override
Line 79:                     public MapSqlParameterSource map(VmStatistics 
entity) {
Line 80:                         MapSqlParameterSource paramValue = new 
MapSqlParameterSource();
Line 81: 
Line 82:                         paramValue.addValue("cpu_sys", 
entity.getcpu_sys());
same
Line 83:                         paramValue.addValue("cpu_user", 
entity.getcpu_user());
Line 84:                         paramValue.addValue("elapsed_time", 
entity.getelapsed_time());
Line 85:                         paramValue.addValue("usage_cpu_percent", 
entity.getusage_cpu_percent());
Line 86:                         paramValue.addValue("usage_mem_percent", 
entity.getusage_mem_percent());


-- 
To view, visit http://gerrit.ovirt.org/16066
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3e9735f4174ebabbe293d397d931aba72bbbd7b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to