Gal Hammer has posted comments on this change.

Change subject: Adjusting the ovirt-guest-agent to the new way of SSO
......................................................................


Patch Set 5: (1 inline comment)

I don't understand what you tried to do here. Did you just want to get rid of 
the random token?

....................................................
File kdm-plugin/src/kgreet_ovirtcred.cpp
Line 149: 
Line 150: void KOVirtCredGreeter::userAuthenticated(QString token)
Line 151: {
Line 152:     m_token = token;
Line 153: 
Didn't you change the userAuthenticated signal to not use a token?
Line 154:     handler->gplugStart();
Line 155: }
Line 156: 
Line 157: static bool init(const QString &,


-- 
To view, visit http://gerrit.ovirt.org/15502
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib47739dc4fea825c116c8404a1b65cdb66ed2ebb
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to