Omer Frenkel has posted comments on this change.
Change subject: engine: Report when vm gets less the Guaranteed memory
......................................................................
Patch Set 3: (3 inline comments)
next time please separate refactoring/cleanups from actual changes
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java
Line 130: this.usage_mem_percentField = value;
Line 131: }
Line 132:
Line 133: // NOT PRESISTED
Line 134: private Integer currentMemory;
is it current memory or balloon current memory?
Line 135:
Line 136: public Integer getCurrentMemory() {
Line 137: return currentMemory;
Line 138: }
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 304: VM_PAUSED_ERROR=VM ${VmName} has paused due to unknown storage error.
Line 305: VM_PAUSED_EIO=VM ${VmName} has paused due to storage I/O problem.
Line 306: VM_PAUSED_EPERM=VM ${VmName} has paused due to storage permissions
problem.
Line 307: VM_POWER_DOWN_FAILED=Shutdown of VM ${VmName} failed.
Line 308: VM_MEMORY_UNDER_GUARANTEED_VALUE=VM ${VmName} has less then the
guaranteed memory
*than
Line 309: VDS_INSTALL=Host ${VdsName} installed
Line 310: VDS_INSTALL_FAILED=Host ${VdsName} installation failed.
${FailedInstallMessage}.
Line 311: VDS_INITIALIZING=Host ${VdsName} is initializing. Message:
${ErrorMessage}
Line 312: VDS_INITIATED_RUN_VM=VM ${VmName} was restarted on Host ${VdsName}
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 1309: VM savedVm =
_vmDict.get(vmInternalData.getVmDynamic().getId());
Line 1310: if (vmInternalData.getVmStatistics().getCurrentMemory()
!= null &&
Line 1311: savedVm.getMinAllocatedMem() >
vmInternalData.getVmStatistics().getCurrentMemory()) {
Line 1312: AuditLogableBase auditLogable = new
AuditLogableBase();
Line 1313: auditLogable.setVmId(savedVm.getId());
add also host name/id
Line 1314: AuditLogDirector.log(auditLogable,
AuditLogType.VM_MEMORY_UNDER_GUARANTEED_VALUE);
Line 1315: }
Line 1316:
Line 1317: }
--
To view, visit http://gerrit.ovirt.org/16949
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47d32f291f39f0ab51c4e5d20a34ab01b47db562
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
