Arik Hadas has posted comments on this change.

Change subject: engine: Report when vm gets less the Guaranteed memory
......................................................................


Patch Set 4: Looks good to me, but someone else must approve

(1 inline comment)

minor comment

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java
Line 10: public class VmStatistics implements BusinessEntity<Guid>, 
Comparable<VmStatistics> {
Line 11:     private static final long serialVersionUID = -7480866662740734452L;
Line 12: 
Line 13:     private Double cpu_sysField = 0.0;
Line 14:     // NOT PRESISTED
PRESISTED => PERSISTED
Line 15:     private Integer currentMemory;
Line 16: 
Line 17:     @Override
Line 18:     public int hashCode() {


-- 
To view, visit http://gerrit.ovirt.org/16949
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I47d32f291f39f0ab51c4e5d20a34ab01b47db562
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to