Douglas Schilling Landgraf has posted comments on this change.
Change subject: HostGeneralModel: improve "node has upgrade" logic
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
Line 674: String nodeVersion[] = nodeInfo[1].trim().split("\\.");
//$NON-NLS-1$
Line 675: String isoVersion[] = iso.getValue().trim().split("\\.");
//$NON-NLS-1$
Line 676:
Line 677: // We support only upgrade with the same major version
Line 678: if (Integer.parseInt(isoVersion[0]) ==
Integer.parseInt(nodeVersion[0])) {
iso is in RpmVersion. However, I don't get what exactly is your suggestion is.
We have the iso which is in RpmVersion and I am splitting it to get the major,
minor and build to compare against the host. Do you want to a new function
inside RpmVersion to compare these data or return these data as member os
object to be used to compare? Also, I have confirmed right now with Mike burns
that we could have two builds in different dates with the same major,minor and
build. The "release" that differs between then is the date. So, next patch I
will introduce back the initial date compare.
Line 679: // isoVersion minor or build should be higher then
node
Line 680: if (Integer.parseInt(isoVersion[1]) >
Integer.parseInt(nodeVersion[1]) ||
Line 681: Integer.parseInt(isoVersion[2]) >
Integer.parseInt(nodeVersion[2])) {
Line 682: alert = true;
--
To view, visit http://gerrit.ovirt.org/16089
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I49c74d3d0d92c74848e0c175095610b6e6b5a88e
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
