Alon Bar-Lev has posted comments on this change.
Change subject: HostGeneralModel: improve "node has upgrade" logic
......................................................................
Patch Set 7: (2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
Line 669: {
Line 670: boolean alert = false;
Line 671:
Line 672: for (RpmVersion iso: isos) {
Line 673: if (iso.compareTo(hostOs) > 0) {
but you need to compare the major explicitly so that it '=='
Line 674: alert = true;
Line 675: break;
Line 676: }
Line 677: }
Line 1094: VDS vds =
hostGeneralModel.getEntity();
Line 1095: String [] Host =
vds.getHostOs().split("-"); //$NON-NLS-1$ //$NON-NLS-2$
Line 1096: String NodeRPMVersion =
Host[1].trim() + "." + Host[2].split("\\.")[0].trim(); //$NON-NLS-1$
//$NON-NLS-2$
Line 1097: Version hostOS = new
Version(NodeRPMVersion);
Line 1098:
hostGeneralModel.setHasUpgradeAlert(shouldAlertUpgrade(isos, hostOS));
I don't think that we should use regex anyway... we can just search for '-'
with number after it...
Line 1099:
Line 1100: boolean executionAllowed =
vds.getStatus() != VDSStatus.Up
Line 1101: && vds.getStatus() !=
VDSStatus.Installing
Line 1102: && vds.getStatus() !=
VDSStatus.PreparingForMaintenance
--
To view, visit http://gerrit.ovirt.org/16089
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I49c74d3d0d92c74848e0c175095610b6e6b5a88e
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
