Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: preserve engine http(s) config ......................................................................
Patch Set 1: (1 inline comment) .................................................... File packaging/setup/ovirt_engine_setup/constants.py Line 776: WEBSOCKET_PROXY_PORT = 'OVESETUP_CONFIG/websocketProxyPort' Line 777: PRESERVE_ENGINE_HTTP = 'OVESETUP_CONFIG/preserveEngineHttp' Line 778: PRESERVE_ENGINE_HTTPS = 'OVESETUP_CONFIG/preserveEngineHttps' Line 779: LEGACY_ENGINE_HTTP_PORT = 'OVESETUP_CONFIG/legacyEngineHttpPort' Line 780: LEGACY_ENGINE_HTTPS_PORT = 'OVESETUP_CONFIG/legacyEngineHttpsPort' hi! can't we have JBOSS_DIRECT_HTTP, JBOSS_DIRECT_HTTPS which can be either None or have value, make the devenv use these and also the legacy plugin? Line 781: Line 782: MAC_RANGE_POOL = 'OVESETUP_CONFIG/macRangePool' Line 783: Line 784: @osetupattrs( -- To view, visit http://gerrit.ovirt.org/17310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f62d8462dd0798b0239d5bdb12af527651ac0f5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
