Alon Bar-Lev has posted comments on this change.

Change subject: packaging: setup: preserve engine http(s) config
......................................................................


Patch Set 2: (1 inline comment)

Yes, looks much better.

....................................................
File packaging/setup/plugins/ovirt-engine-setup/legacy/config.py
Line 131:             for n in glob.glob(os.path.join(legacy_confd, '*.conf')):
Line 132:                 with open(n, 'r') as f:
Line 133:                     self.environment[
Line 134:                         otopicons.CoreEnv.MAIN_TRANSACTION
Line 135:                     ].append(
Don't think that this is required.
Line 136:                         filetransaction.FileTransaction(
Line 137:                             name=os.path.join(
Line 138:                                 (
Line 139:                                     osetupcons.FileLocations.


-- 
To view, visit http://gerrit.ovirt.org/17310
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f62d8462dd0798b0239d5bdb12af527651ac0f5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to