Lee Yarwood has uploaded a new change for review. Change subject: core: Include tracebacks in QueriesCommandBase errors. ......................................................................
core: Include tracebacks in QueriesCommandBase errors. At present DEBUG logging is required to view a full trace of exceptions caught by the QueriesCommandBase class. These really should be present by default within the ERROR line. Change-Id: I48fa907c9e6cf7365768f90b2dd90d167114f051 Signed-off-by: Lee Yarwood <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java 1 file changed, 5 insertions(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/50/17350/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java index cc8d817..0e606a1 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java @@ -73,19 +73,15 @@ } else { returnValue.setExceptionString(vdcExc.getMessage()); } - log.errorFormat("Query {0} failed. Exception message is {1}", + log.errorFormat("Query {0} failed. Exception message is {1} : {2}", getClass().getSimpleName(), - vdcExc.getMessage()); - if (log.isDebugEnabled()) { - log.debugFormat("Detailed stacktrace:", vdcExc); - } + vdcExc.getMessage(), vdcExc); + } else { returnValue.setExceptionString(ex.getMessage()); - log.errorFormat("Query {0} failed. Exception message is {1}", + log.errorFormat("Query {0} failed. Exception message is {1} : {2}", getClass().getSimpleName(), - ex.getMessage()); - if (log.isDebugEnabled()) { - log.debugFormat("Detailed stacktrace:", ex); + ex.getMessage(), ex); } } } -- To view, visit http://gerrit.ovirt.org/17350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I48fa907c9e6cf7365768f90b2dd90d167114f051 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lee Yarwood <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
