Liran Zelkha has uploaded a new change for review.

Change subject: engine : Dump memory on OutOfMemoryError is now default
......................................................................

engine : Dump memory on OutOfMemoryError is now default

Change the default param of JBoss so that if the engine crash on OutOfMemory,
a dump file will be created, under the LOG/dump directory.

Change-Id: Ia2690bd371847561717a38410b4431f5e0edb185
Signed-off-by: [email protected] <[email protected]>
---
M Makefile
M packaging/services/ovirt-engine/ovirt-engine.conf.in
M packaging/sys-etc/logrotate.d/ovirt-engine.in
3 files changed, 12 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/66/17466/1

diff --git a/Makefile b/Makefile
index 98bdac5..37af58a 100644
--- a/Makefile
+++ b/Makefile
@@ -59,6 +59,7 @@
 PKG_JBOSS_MODULES=$(DATA_DIR)/modules
 PKG_CACHE_DIR=$(LOCALSTATE_DIR)/cache/$(ENGINE_NAME)
 PKG_LOG_DIR=$(LOCALSTATE_DIR)/log/$(ENGINE_NAME)
+PKG_DUMP_DIR=${PKG_LOG_DIR)/dump
 PKG_TMP_DIR=$(LOCALSTATE_DIR)/tmp/$(ENGINE_NAME)
 PKG_STATE_DIR=$(LOCALSTATE_DIR)/lib/$(ENGINE_NAME)
 SPICE_DIR=/usr/share/spice
@@ -452,3 +453,4 @@
        install -d "$(DESTDIR)$(PKG_LOG_DIR)/setup"
        install -d "$(DESTDIR)$(PKG_LOG_DIR)/notifier"
        install -d "$(DESTDIR)$(PKG_LOG_DIR)/engine-manage-domains"
+       install -d "$(DESTDIR)$(PKG_DUMP_DIR)"
diff --git a/packaging/services/ovirt-engine/ovirt-engine.conf.in 
b/packaging/services/ovirt-engine/ovirt-engine.conf.in
index 4d1f2b6..462efc0 100644
--- a/packaging/services/ovirt-engine/ovirt-engine.conf.in
+++ b/packaging/services/ovirt-engine/ovirt-engine.conf.in
@@ -101,7 +101,7 @@
 #
 #   -Dmy.param=my.value -Dmy.flag -Dyour.param=your.value
 #
-ENGINE_PROPERTIES=jsse.enableSNIExtension=false
+ENGINE_PROPERTIES=jsse.enableSNIExtension=false 
-XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=${ENGINE_LOG}/dump
 
 #
 # Additional applications to be deployed in the instance of the
diff --git a/packaging/sys-etc/logrotate.d/ovirt-engine.in 
b/packaging/sys-etc/logrotate.d/ovirt-engine.in
index 7151e35..7b10997 100644
--- a/packaging/sys-etc/logrotate.d/ovirt-engine.in
+++ b/packaging/sys-etc/logrotate.d/ovirt-engine.in
@@ -14,3 +14,12 @@
        nocreate
        rotate 1
 }
+
+"@ENGINE_LOG@/dump"/*.log {
+        monthly
+        missingok
+        compress
+        nocreate
+        rotate 1
+}
+


-- 
To view, visit http://gerrit.ovirt.org/17466
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2690bd371847561717a38410b4431f5e0edb185
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to