Liran Zelkha has posted comments on this change.

Change subject: engine : Dump memory on OutOfMemoryError is now default
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File packaging/services/ovirt-engine/ovirt-engine.conf.in
Line 100: # the same line and separated by spaces:
Line 101: #
Line 102: #   -Dmy.param=my.value -Dmy.flag -Dyour.param=your.value
Line 103: #
Line 104: ENGINE_PROPERTIES=jsse.enableSNIExtension=false 
-XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=${ENGINE_LOG}/dump
We'll need to wrap it in ", and escape spaces. Do you have a method that does 
that?
Line 105: 
Line 106: #
Line 107: # Additional applications to be deployed in the instance of the
Line 108: # application server started by the engine. This is a list of space


-- 
To view, visit http://gerrit.ovirt.org/17466
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2690bd371847561717a38410b4431f5e0edb185
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to