Laszlo Hornyak has posted comments on this change.

Change subject: engine: fix add watchdog
......................................................................


Patch Set 2: Verified

verified 
- create:
curl -H "Content-type: application/xml" -d 
"<watchdog><model>i6300esb</model><action>poweroff</action></watchdog>" -X POST 
-u admin@internal:letmein 
http://localhost:8080/api/vms/500e6d53-f300-4822-b854-3e41d484934e/watchdogs
- read:
  - collection:
    curl -u admin@internal:letmein 
http://localhost:8080/api/vms/500e6d53-f300-4822-b854-3e41d484934e/watchdogs
  - entity:
    curl -u admin@internal:letmein 
http://localhost:8080/api/vms/500e6d53-f300-4822-b854-3e41d484934e/watchdogs/00000000-0000-0000-0000-000000000000
- update:
  curl -H "Content-type: application/xml" -d 
"<watchdog><model>i6300esb</model><action>reset</action></watchdog>" -X PUT -u 
admin@internal:letmein 
http://localhost:8080/api/vms/500e6d53-f300-4822-b854-3e41d484934e/watchdogs/00000000-0000-0000-0000-000000000000
- delete:
  curl -u admin@internal:letmein -X DELETE 
http://localhost:8080/api/vms/500e6d53-f300-4822-b854-3e41d484934e/watchdogs/00000000-0000-0000-0000-000000000000

- negative tests:
  - create with already existing watchdog
  - create with bad enums:
    curl -H "Content-type: application/xml" -d 
"<watchdog><model>i6300esb</model><action>uncavallo</action></watchdog>" -X 
POST -u admin@internal:letmein 
http://localhost:8080/api/vms/500e6d53-f300-4822-b854-3e41d484934e/watchdogs
  - update with bad enum:
    curl -H "Content-type: application/xml" -d 
"<watchdog><model>i6300esb</model><action>uncavallo</action></watchdog>" -X PUT 
-u admin@internal:letmein 
http://localhost:8080/api/vms/500e6d53-f300-4822-b854-3e41d484934e/watchdogs/00000000-0000-0000-0000-000000000000

All these looked ok.

-- 
To view, visit http://gerrit.ovirt.org/17434
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95362fda69b8ec7c02893ba30cdf19be7eee5eac
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to