Michael Pasternak has posted comments on this change. Change subject: restapi: extend ReadOnly interface to Resources ......................................................................
Patch Set 2: Do not submit at the beginning we wanted to have a clear isolation between device and regular resource, as time has passed by, this became not important, even if this change make sense now, i would not go with it (at least in this stage of 3.3) because of the noise it may create, - we using a lot of reflection work behind the scene and it may cause not trivial issues - RestEasy known as easily breakable by generic interfaces, what is not seen via unittests instead you could create ReadOnlyResource and make ReadOnlyDeviceResource extending it -- To view, visit http://gerrit.ovirt.org/17347 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic77b92b0e696e8ad0a0095006772320ac2f0600a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
