Yair Zaslavsky has posted comments on this change.
Change subject: [WIP] Add generic directory support to the AddUserCommand
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java
Line 49: } else if (getParameters().getAdGroup() != null) {
Line 50: addCustomValue("NewUserName",
getParameters().getAdGroup().getname());
Line 51: userId = getParameters().getAdGroup().getid();
Line 52: domain = getParameters().getAdGroup().getdomain();
Line 53: Directory directory =
DirectoryManager.getInstance().getDirectory(domain);
same comment as before about getDirectoryManager()
Line 54: if (directory == null) {
Line 55:
addCanDoActionMessage(VdcBllMessages.USER_MUST_EXIST_IN_DIRECTORY);
Line 56: return false;
Line 57: }
--
To view, visit http://gerrit.ovirt.org/15771
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0bcf801c498a50c8d9093784284e7ab3448f772
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
