Yair Zaslavsky has posted comments on this change.
Change subject: [WIP] Introduce new authenticator interface
......................................................................
Patch Set 4:
(1 comment)
....................................................
File
backend/manager/modules/auth/src/main/java/org/ovirt/engine/core/authenticator/AuthenticatorFilter.java
Line 45: // Nothing.
Line 46: }
Line 47:
Line 48: @Override
Line 49: public void doFilter(ServletRequest req, ServletResponse res,
FilterChain chain) throws IOException, ServletException {
+1 on Ravi's comment.
Line 50: // Cast the request and response to the HTTP specific types,
as this is
Line 51: // all what we support:
Line 52: HttpServletRequest request = (HttpServletRequest) req;
Line 53: HttpServletResponse response = (HttpServletResponse) res;
--
To view, visit http://gerrit.ovirt.org/15597
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11635c21917401ac7c882fa3233010c804dfb91f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
