Yair Zaslavsky has posted comments on this change.

Change subject: core: Change enum JSON deserialization
......................................................................


Patch Set 4:

(1 comment)

....................................................
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializer.java
Line 46:         
formattedMapper.getDeserializationConfig().addMixInAnnotations(VmBase.class, 
JsonVmBaseMixIn.class);
Line 47:         
formattedMapper.getDeserializationConfig().addMixInAnnotations(VmStatic.class, 
JsonVmStaticMixIn.class);
Line 48:         formattedMapper.configure(Feature.FAIL_ON_UNKNOWN_PROPERTIES, 
false);
Line 49:         formattedMapper.enableDefaultTyping();
Line 50:         formattedMapper.setDeserializerProvider(new 
JsonObjectDeserializerProvider());
Comment to myself - probably we can have a static member of 
JsonObjectDeserializerProvider and spare the "new" per instantiation of 
JsonObjectDeserializer.
Line 51:     }
Line 52: 
Line 53:     @Override
Line 54:     public <T extends Serializable> T deserialize(Object source, 
Class<T> type) throws SerializationExeption {


-- 
To view, visit http://gerrit.ovirt.org/17951
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d6f2e4a02eeda999e525101c2f54789a34cfaf
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to