mooli tayer has posted comments on this change. Change subject: frontend: changes in add permissions popup ......................................................................
Patch Set 2: Sorry for taking long to reply. I agree getting the current domain could have been done in UserPortalAdElementListModel. The reason why I implemented it in GetDomainListQuery is that I wanted to keep all the logic in getting the domains in one place. I see the advantages in your suggestion (one less async query in some cases, less code change) i prefer it when similar things work in a similar flow (doing a backend query to get domains) What do you say? -- To view, visit http://gerrit.ovirt.org/16036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6084b6b100c5fbb39a9d7738661bad69b3aaa8e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
