Juan Hernandez has posted comments on this change. Change subject: frontend: changes in add permissions popup ......................................................................
Patch Set 2: I would prefer to have a clean and simple query, and let the GUI do the ugly part of using it or not if it already knows the result. In fact it would be nice if this query didn't even have to worry about including or not including the internal domain. But it is just that, a personal preference, I don't have strong arguments to defend it. -- To view, visit http://gerrit.ovirt.org/16036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6084b6b100c5fbb39a9d7738661bad69b3aaa8e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
