Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: text changes
......................................................................
Patch Set 1:
(4 comments)
....................................................
File packaging/setup/ovirt_engine_setup/constants.py
Line 939:
Line 940: @osetupattrs(
Line 941: answerfile=True,
Line 942: summary=True,
Line 943: description=_('Set application as root page'),
I suggest 'Redirect web domain root to application home page'
Line 944: postinstallfile=True,
Line 945: )
Line 946: def CONFIGURE_ROOT_REDIRECTION(self):
Line 947: return 'OVESETUP_APACHE/configureRootRedirection'
....................................................
File packaging/setup/plugins/ovirt-engine-setup/apache/root.py
Line 82: osetupcons.ApacheEnv.CONFIGURE_ROOT_REDIRECTION
Line 83: ] is None:
Line 84: self.dialog.note(
Line 85: _(
Line 86: 'Setup can configure the root page of the '
s/root/domain root/
Line 87: 'web server to present the ovirt-engine
application. '
Line 88: 'This may conflict with existing applications.'
Line 89: )
Line 90: )
Line 83: ] is None:
Line 84: self.dialog.note(
Line 85: _(
Line 86: 'Setup can configure the root page of the '
Line 87: 'web server to present the ovirt-engine
application. '
I suggest to remove ovirt-engine and use 'application home page'
Line 88: 'This may conflict with existing applications.'
Line 89: )
Line 90: )
Line 91: self.environment[
Line 93: ] = dialog.queryBoolean(
Line 94: dialog=self.dialog,
Line 95: name='OVESETUP_APACHE_CONFIG_ROOT_REDIRECTION',
Line 96: note=_(
Line 97: 'Do you wish to set ovirt-engine as the root page
of '
same here
Line 98: 'the web server? (@VALUES@) [@DEFAULT@]: '
Line 99: ),
Line 100: prompt=True,
Line 101: default=self.environment[
--
To view, visit http://gerrit.ovirt.org/18053
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2a50fdb2e3b2281fafa894b8e95c7902ba24380
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
