Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: text changes
......................................................................
Patch Set 3:
(2 comments)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/distro-rpm/packages.py
Line 338: packages=(osetupcons.Const.ENGINE_PACKAGE_SETUP_NAME,)
Line 339: ):
Line 340: self.logger.error(
Line 341: _(
Line 342: 'An update for the Setup package "{package}"
was '
I decided it's best. Otherwise we need to use 'engine-setup' in some places,
'ovirt-engine-setup package' in others etc. Capitalizing emphasizes that we
talk about a specific object and not a general term. I am far from an English
expert.
Line 343: 'found. Please update that package, e.g. by
running '
Line 344: '"yum update {package}", and then execute
Setup again.'
Line 345: ).format(
Line 346:
package=osetupcons.Const.ENGINE_PACKAGE_SETUP_NAME,
Line 368:
name='OVESETUP_RPMDISTRO_REQUIRE_ROLLBACK',
Line 369: note=_(
Line 370: 'Setup will not be able to rollback
new '
Line 371: 'packages in case of a failure
because '
Line 372: 'existing ones are missing at the
repository. '
Done
Line 373: 'Do you want to continue anyway? '
Line 374: '(@VALUES@) [@DEFAULT@]: '
Line 375: ),
Line 376: prompt=True,
--
To view, visit http://gerrit.ovirt.org/18053
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2a50fdb2e3b2281fafa894b8e95c7902ba24380
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
