Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: allinone: non-standard ssh port
......................................................................
Patch Set 1:
(3 comments)
....................................................
File packaging/setup/ovirt_engine_setup/constants.py
Line 1041
Line 1042
Line 1043
Line 1044
Line 1045
why PKI?
....................................................
File packaging/setup/plugins/ovirt-engine-setup/all-in-one/sshd.py
Line 60: def _setup(self):
Line 61: self._enabled = not self.environment[
Line 62: osetupcons.CoreEnv.DEVELOPER_MODE
Line 63: ]
Line 64: self.command.detect('sshd')
I don't like running the daemon... just use default... unless overridden...
much safer.
Line 65:
Line 66: @plugin.event(
Line 67: stage=plugin.Stages.STAGE_CUSTOMIZATION,
Line 68: condition=lambda self: (
Line 92: if words[0] == 'port':
Line 93: self.environment[
Line 94: osetupcons.AIOEnv.SSHD_PORT
Line 95: ] = int(words[1])
Line 96: break
I don't like these magics... one day we would like to use this module to
install remote hosts... and we created a dependency in local configuration...
Just set default osetupcons.AIOEnv.SSHD_PORT with 22, allowing user to override.
Line 97:
Line 98: @plugin.event(
Line 99: stage=plugin.Stages.STAGE_MISC,
Line 100: condition=lambda self: (
--
To view, visit http://gerrit.ovirt.org/18174
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd8a4cad5f0b480f04392933cd7c6e1b512c564d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
