Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: allinone: non-standard ssh port ......................................................................
Patch Set 2: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/all-in-one/sshd.py Line 92: if words[0] == 'port': Line 93: self.environment[ Line 94: osetupcons.AIOEnv.SSHD_PORT Line 95: ] = int(words[1]) Line 96: break I always put deterministic code... If for some reason this command fails... or any other reason, we cannot keep none in variable. the default cannot be 22 at _init as we need to know if user overwrite or not. Line 97: Line 98: @plugin.event( Line 99: stage=plugin.Stages.STAGE_MISC, Line 100: condition=lambda self: ( -- To view, visit http://gerrit.ovirt.org/18174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd8a4cad5f0b480f04392933cd7c6e1b512c564d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
