Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: allinone: DC version
......................................................................
Patch Set 3:
(1 comment)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/all-in-one/vdsm.py
Line 209: )
Line 210: ).version
Line 211: engine_version = self._ovirtsdk_xml.params.Version(
Line 212: major=v[0],
Line 213: minor=v[1],
That's theoretical, assuming we'll allow downgrading in the future.
E.g. if the original install was not all-in-one but during downgrade user
selected to install it.
We are spending a long time on a very simple thing. Do you see a problem with
also checking the package version?
Line 214: )
Line 215:
Line 216: self.logger.debug('Creating the local data center')
Line 217: engine_api.datacenters.add(
--
To view, visit http://gerrit.ovirt.org/18172
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I01054b74f26fc961633d8f0a55429569dcc8cc31
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Lev Veyde <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
