Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: allinone: DC version
......................................................................
Patch Set 6:
(2 comments)
....................................................
File packaging/setup/plugins/ovirt-engine-common/system/apache.py
Line 63: stage=plugin.Stages.STAGE_CLOSEUP,
Line 64: name=osetupcons.Stages.APACHE_RESTART,
Line 65: after=(
Line 66: osetupcons.Stages.CORE_ENGINE_START,
Line 67: ),
please do this in separate patch.
Line 68: condition=lambda self: (
Line 69: self._enabled and
Line 70: self.environment[
Line 71: osetupcons.ApacheEnv.NEED_RESTART
....................................................
File packaging/setup/plugins/ovirt-engine-setup/all-in-one/vdsm.py
Line 201: levels=SupportedClusterLevels,
Line 202: pv=osetupconfig.PACKAGE_VERSION,
Line 203: )
Line 204: )
Line 205: v = max(distutils.version.LooseVersion(vs).version
I think the convention is:
v = max(
[
distutils.version.LooseVersion(vs).version
for vs in SupportedClusterLevels.split(',')
]
)
I mean explicit list... no?
But if not still new line is required:
v = max(
distutils.version.LooseVersion(vs).version
for vs in SupportedClusterLevels.split(',')
)
Line 206: for vs in SupportedClusterLevels.split(',')
Line 207: )
Line 208: engine_version = self._ovirtsdk_xml.params.Version(
Line 209: major=v[0],
--
To view, visit http://gerrit.ovirt.org/18172
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I01054b74f26fc961633d8f0a55429569dcc8cc31
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Lev Veyde <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
