Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: enhance line uninstall
......................................................................
Patch Set 3:
(5 comments)
....................................................
File packaging/setup/plugins/ovirt-engine-common/core/uninstall.py
Line 149: )
Line 150: if 'added' in content:
Line 151: config.set(
Line 152: section,
Line 153: prefix + '.content_added',
minor: I think better to use .content.*
Line 154: content['added'],
Line 155: )
Line 156: if 'removed' in content:
Line 157: config.set(
....................................................
File packaging/setup/plugins/ovirt-engine-remove/files/simple.py
Line 67
Line 68
Line 69
Line 70
Line 71
remove_lines -> content?
Line 88: #should me updated or added
Line 89: if line in replace:
Line 90: line = replace[line]
Line 91: new_content.append(line)
Line 92: new_content.extend(just_add)
I would have looped the opposite:
for l in lines:
for entry in content_change:
if entry.remove == l:
if entry.add is not None:
result.append(entry.add)
else:
result.append(l)
for entry in content_change:
if entry.add is not None and entry.remove is None:
result.append(entry.add)
Line 93:
Line 94: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append(
Line 95: filetransaction.FileTransaction(
Line 96: name=filename,
Line 209: )[comps[2]] = value
Line 210: for f in associated_lines.values():
Line 211: aggregated_lines.setdefault(
Line 212: f['name'], []
Line 213: ).append(
better to use dict?
Line 214: (
Line 215: f.get('content_added', None),
Line 216: f.get('content_removed', None),
Line 217: )
....................................................
File packaging/setup/plugins/ovirt-engine-setup/distro-rpm/packages.py
Line 136
Line 137
Line 138
Line 139
Line 140
addContent instead?
--
To view, visit http://gerrit.ovirt.org/16768
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69ab434de8fb675c67ac5d1907879e465e587dbf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
