Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: enhance line uninstall ......................................................................
Patch Set 3: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-remove/files/simple.py Line 88: #should me updated or added Line 89: if line in replace: Line 90: line = replace[line] Line 91: new_content.append(line) Line 92: new_content.extend(just_add) Sorry... now I understand that it is single entry per file... so no need to loop and such... line.000003.name = /etc/yum/pluginconf.d/versionlock.list line.000003.content_added = ovirt-engine-restapi-3.4.0-0.2.master.20130825182254.fc19.noarch line.000004.name = /etc/yum/pluginconf.d/versionlock.list line.000004.content_added = ovirt-engine-tools-3.4.0-0.2.master.20130825182254.fc19.noarch line.000005.name = /etc/yum/pluginconf.d/versionlock.list line.000005.content_added = ovirt-engine-userportal-3.4.0-0.2.master.20130825182254.fc19.noarch In this case for each entry we can just replace line using list index remove/add, no? Line 93: Line 94: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append( Line 95: filetransaction.FileTransaction( Line 96: name=filename, -- To view, visit http://gerrit.ovirt.org/16768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69ab434de8fb675c67ac5d1907879e465e587dbf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
