Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: firewalld services cleanup ......................................................................
Patch Set 1: (2 comments) So this is working with legacy and newer services, right? .................................................... File packaging/setup/plugins/ovirt-engine-remove/network/firewalld.py Line 43: after=( Line 44: osetupcons.Stages.REMOVE_CUSTOMIZATION_GROUPS, Line 45: ), Line 46: ) Line 47: def _customization(self): move to validation? Line 48: enable_firewalld = False Line 49: for file in self.environment[osetupcons.RemoveEnv.FILES_TO_REMOVE]: Line 50: if file.startswith( Line 51: osetupcons.FileLocations.FIREWALLD_SERVICES_DIR .................................................... File packaging/setup/plugins/ovirt-engine-setup/legacy/firewalld.py Line 45 Line 46 Line 47 Line 48 Line 49 better do this in validation -- To view, visit http://gerrit.ovirt.org/18479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c36ee32302a93edabb06f90c12c3caedc9d4129 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
