Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: firewalld services cleanup ......................................................................
Patch Set 1: (1 comment) I verified that a clean install works and that a rollback during an upgrade from 3.2 works well (removes ovirt service and re-adds it during rollback). .................................................... File packaging/setup/plugins/ovirt-engine-remove/network/firewalld.py Line 43: after=( Line 44: osetupcons.Stages.REMOVE_CUSTOMIZATION_GROUPS, Line 45: ), Line 46: ) Line 47: def _customization(self): Can you explain the comment in packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py: # must be at customization as otopi modules # need a chance to validate content In otopi, customization only checks version and validation only checks "enabled". misc gets the content and prepares a filetransaction, but does not actually verify the content or anything like that. Since I did not understand this comment, and thought I might be missing something, I hesitated to change stages. Line 48: enable_firewalld = False Line 49: for file in self.environment[osetupcons.RemoveEnv.FILES_TO_REMOVE]: Line 50: if file.startswith( Line 51: osetupcons.FileLocations.FIREWALLD_SERVICES_DIR -- To view, visit http://gerrit.ovirt.org/18479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c36ee32302a93edabb06f90c12c3caedc9d4129 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
