Shubhendu Tripathi has posted comments on this change. Change subject: <WIP> engine: BLL Command to Stop Reblance Gluster Volume task ......................................................................
Patch Set 2: (2 comments) .................................................... File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties Line 291: VAR__ACTION__HOT_UNPLUG=$action hot unplug Line 292: VAR__ACTION__LOGON=$action log on Line 293: VAR__ACTION__LOGOFF=$action log off Line 294: VAR__ACTION__ASSIGN=$action assign Line 295: VAR__ACTION__REBALANCE_START=$action rebalance What would be the value of action here? I feel start/stop would be coming as action only so do we really need two different entries for VAR_ACTION. Not so sure. Line 296: VAR__ACTION__REBALANCE_STOP=$action stop rebalance Line 297: VAR__ACTION__START_PROFILE=$action start profiling Line 298: VAR__ACTION__STOP_PROFILE=$action stop profiling Line 299: VAR__ACTION__ENABLE=$action enable .................................................... File frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties Line 294: VAR__ACTION__HOT_PLUG=$action hot plug Line 295: VAR__ACTION__HOT_UNPLUG=$action hot unplug Line 296: VAR__ACTION__LOGON=$action log on Line 297: VAR__ACTION__LOGOFF=$action log off Line 298: VAR__ACTION__REBALANCE_START=$action rebalance What would be the value of action here? I feel start/stop would be coming as action only so do we really need two different entries for VAR_ACTION. Not so sure. Line 299: VAR__ACTION__REBALANCE_STOP=$action stop rebalance Line 300: VAR__ACTION__START_PROFILE=$action start profiling Line 301: VAR__ACTION__STOP_PROFILE=$action stop profiling Line 302: VAR__ACTION__ASSIGN=$action assign -- To view, visit http://gerrit.ovirt.org/18445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e7cf0eb4de160dc309f2699ba0e224f48dd1f49 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
