Sahina Bose has posted comments on this change.
Change subject: engine: BLL Command to Stop Reblance Gluster Volume task
......................................................................
Patch Set 7:
(5 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRebalanceGlusterVolumeCommand.java
Line 36: if (!super.canDoAction()) {
Line 37: return false;
Line 38: }
Line 39:
Line 40: if (!glusterVolume.isOnline()) {
You can move this check to superclass
Line 41:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_GLUSTER_VOLUME_SHOULD_BE_STARTED);
Line 42: return false;
Line 43: }
Line 44:
Line 56: return StepEnum.REBALANCING_VOLUME;
Line 57: }
Line 58:
Line 59: @Override
Line 60: protected void executeCommand() {
use runVdsCommand method of superclass
Line 61: VDSReturnValue vdsReturnaValue =
Backend.getInstance().getResourceManager()
Line 62:
.RunVdsCommand(VDSCommandType.StopRebalanceGlusterVolume,
Line 63: new
GlusterVolumeVDSParameters(upServer.getId(),
Line 64: getGlusterVolumeName()));
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java
Line 69:
AddEventNotificationEntry(EventNotificationEntity.GlusterVolume,
AuditLogType.GLUSTER_VOLUME_REMOVE_BRICKS_FAILED);
Line 70:
AddEventNotificationEntry(EventNotificationEntity.GlusterVolume,
AuditLogType.GLUSTER_VOLUME_REBALANCE_START);
Line 71:
AddEventNotificationEntry(EventNotificationEntity.GlusterVolume,
AuditLogType.GLUSTER_VOLUME_REBALANCE_START_FAILED);
Line 72:
AddEventNotificationEntry(EventNotificationEntity.GlusterVolume,
AuditLogType.GLUSTER_VOLUME_REBALANCE_STOP);
Line 73:
AddEventNotificationEntry(EventNotificationEntity.GlusterVolume,
AuditLogType.GLUSTER_VOLUME_REBALANCE_STOP_FAILED);
Also add entries in event_map table
Line 74:
AddEventNotificationEntry(EventNotificationEntity.GlusterVolume,
AuditLogType.GLUSTER_VOLUME_REPLACE_BRICK_FAILED);
Line 75:
AddEventNotificationEntry(EventNotificationEntity.GlusterVolume,
AuditLogType.GLUSTER_VOLUME_REPLACE_BRICK_START);
Line 76:
AddEventNotificationEntry(EventNotificationEntity.GlusterVolume,
AuditLogType.GLUSTER_VOLUME_REPLACE_BRICK_START_FAILED);
Line 77: AddEventNotificationEntry(EventNotificationEntity.Host,
AuditLogType.GLUSTER_SERVER_ADD_FAILED);
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 616: GLUSTER_VOLUME_ADD_BRICK_FAILED=Gluster Volume ${glusterVolumeName}
add brick failed.
Line 617: GLUSTER_VOLUME_REBALANCE_START=Gluster Volume ${glusterVolumeName}
rebalance started.
Line 618: GLUSTER_VOLUME_REBALANCE_START_FAILED=Could not start Gluster Volume
${glusterVolumeName} rebalance.
Line 619: GLUSTER_VOLUME_REBALANCE_STOP=Gluster Volume ${glusterVolumeName}
rebalance stoped.
Line 620: GLUSTER_VOLUME_REBALANCE_STOP_FAILED=Could not top Gluster Volume
${glusterVolumeName} rebalance.
Typo here..Consider changing to "Could not stop rebalance of gluster volume .."
Line 621: GLUSTER_VOLUME_REPLACE_BRICK_FAILED=Replace Gluster Volume Brick
failed
Line 622: GLUSTER_VOLUME_REPLACE_BRICK_START=Gluster Volume
${glusterVolumeName} Replace Brick started.
Line 623: GLUSTER_VOLUME_REPLACE_BRICK_START_FAILED=Could not start Gluster
Volume ${glusterVolumeName} Replace Brick.
Line 624: GLUSTER_SERVER_ADD_FAILED=Failed to add gluster server ${VdsName}
into Cluster ${VdsGroupName}.
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
Line 264:
Line 265: String AuditLogType___GLUSTER_VOLUME_REBALANCE_START();
Line 266:
Line 267: String AuditLogType___GLUSTER_VOLUME_REBALANCE_START_FAILED();
Line 268:
Remove TWS
Line 269: String AuditLogType___GLUSTER_VOLUME_REBALANCE_STOP();
Line 270:
Line 271: String AuditLogType___GLUSTER_VOLUME_REBALANCE_STOP_FAILED();
Line 272:
--
To view, visit http://gerrit.ovirt.org/18445
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e7cf0eb4de160dc309f2699ba0e224f48dd1f49
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
