Thank you James, it would be really impressive if all this functionality could be included in the core.
Just a missing point, what about translations? Cheers. On Thursday 19 February 2009 22:58:00 James Adam wrote: > On 19 Feb 2009, at 19:05, Trevor Rowe wrote: > > I know they are adding a lot to the core of rails, but what about > > the rest? Will the Engines plugin live on to provide the missing > > pieces? > > It's my hope that we'll fold almost all of the significant features of > the engines plugin into Rails itself. Those features are migrations > and public asset copying. > > Samuel Williams pointed out an issue with the current migration > strategy (see the Lighthouse for more info) that I'm keen to resolve > in whatever strategy Rails adopts. My current thinking is that the > schema_migrations table should have an extra column - 'source' - that > would solve this issue. David remains to be convinced, but I hope to > show that it relatively simple. > > Public asset copying shouldn't be very difficult to port. The slight > hurdle is whether or not to bring the engine asset helper extensions > across (i.e. adding the :plugin option to stylesheet_link_tag, etc), > or whether or not assets should be copied into the main folder itself > so the default helpers work. I'm tending towards the latter, as it > will be easier to convince 'core'. > > The only feature that I am not planning on 'campaigning' for is the > code-mixing. This value this was originally intended to bring was to > seamlessly layer plugins on top of each other, but I'm no longer > convinced that this is a goal worth increasing the codebase of Rails > for. There are other, simpler ways to override single methods in a > Ruby class that I'd rather pursue. > > If for any reason migrations or assets don't make it into core, I > think we'll have to fulfil them via an 'engines' plugin for 2.3, but I > hope that won't be necessary :) > > Apologies for not being more transparent with this - I hope it makes > sense. > > Let me know what you think, > > James > _______________________________________________ > Engine-Users mailing list > [email protected] > http://lists.rails-engines.org/listinfo.cgi/engine-users-rails-engines.org _______________________________________________ Engine-Users mailing list [email protected] http://lists.rails-engines.org/listinfo.cgi/engine-users-rails-engines.org
