On 20 Feb 2009, at 10:39, Space Ship Traveller <[email protected]
> wrote:
On 20/02/2009, at 10:32 PM, Antonio Tapiador del Dujo wrote:
Thank you James, it would be really impressive if all this
functionality could
be included in the core.
Just a missing point, what about translations?
Cheers.
On Thursday 19 February 2009 22:58:00 James Adam wrote:
On 19 Feb 2009, at 19:05, Trevor Rowe wrote:
I know they are adding a lot to the core of rails, but what about
the rest? Will the Engines plugin live on to provide the missing
pieces?
It's my hope that we'll fold almost all of the significant
features of
the engines plugin into Rails itself. Those features are migrations
and public asset copying.
Samuel Williams pointed out an issue with the current migration
strategy (see the Lighthouse for more info) that I'm keen to resolve
in whatever strategy Rails adopts. My current thinking is that the
schema_migrations table should have an extra column - 'source' -
that
would solve this issue. David remains to be convinced, but I hope to
show that it relatively simple.
BTW... I've already provided a simple patch to fix this issue, and
it doesn't require another column or anything, it just changes the
order of the name and migration number.
"1-myplugin".to_i == 1 <== problem
"myplugin-1".to_i == nil <== ignored by standard rails.
While this works now, it is a hack which relies on Rails behaviour
that is not intentional.
Adding a column is a more elegant and robust hack, and the more
elegant the solution, the easier it will be to convince core to
integrate it, and this become a hack no more.
James
_______________________________________________
Engine-Users mailing list
[email protected]
http://lists.rails-engines.org/listinfo.cgi/engine-users-rails-engines.org
