On 01/20/2013 09:56 AM, Patrick Brunschwig wrote: > I'm fine with your patch except for the following: > "use strict;" and > "use strict"; > > are not the same. According to Mozilla documentation, the latter > shouldn't do anything at all.
Here's the documentation i've read: https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Functions_and_function_scope/Strict_mode as far as i can tell, it's the former that doesn't do anything at all, not the latter. fwiw, 'use strict'; appears 6 times in enigmail, while 'use strict;' appears twice: 0 dkg@alice:~/src/enigmail/enigmail$ find . -name '*.js*' -print0 | xargs -0 grep -n use\ strict ./ui/content/enigmailMsgHdrViewOverlay.js:36:'use strict;' ./ipc/modules/subprocess.jsm:160:'use strict'; ./ipc/modules/subprocess_worker_unix.js:46:'use strict'; ./ipc/modules/subprocess_worker_win.js:46:'use strict'; ./package/enigMsgCompFields.js:38:'use strict;' ./package/mimeEncrypt.js:11:'use strict'; ./package/mimeDecrypt.js:11:'use strict'; ./package/mimeVerify.jsm:15:'use strict'; 0 dkg@alice:~/src/enigmail/enigmail$ it seems like at least they should be all be one or all be the other. > Your patch is committed. THANKS. Thanks for your review, and (as always) thanks for enigmail! --dkg
signature.asc
Description: OpenPGP digital signature
_______________________________________________ enigmail-users mailing list [email protected] https://admin.hostpoint.ch/mailman/listinfo/enigmail-users_enigmail.net
