-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 20.01.13 17:30, Daniel Kahn Gillmor wrote: > On 01/20/2013 11:21 AM, Patrick Brunschwig wrote: >> On 20.01.13 16:58, Daniel Kahn Gillmor wrote: >> >>> fwiw, 'use strict'; appears 6 times in enigmail, while 'use >>> strict;' appears twice: >> >> Ah, sorry. You're right - my memory played tricks with me ;-) > > I guess i had the advantage of complete ignorance of "use strict" > before a few days ago, so i was forced to look it up :) > > While i'm looking at this, there are 46 javascript files in > enigmail, but only 8 of them have "use strict"; Is there a reason > for this?
Yes. Use strict generates both compile-time and runtime errors. I could easily handle and fix the compile-time errors, but runtime errors require quite a bit of testing. Therefore I decided to use it for new files, and I will introduce it to the old code over time. > would you accept a patch to make them all "use strict"; ? Given the above, no thanks. - -Patrick -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEVAwUBUPwiIck25cDiHiw+AQhk6gf/YLiEtmSAv+2ATZ2MLtZcB4vT7saEe5oo CISmNaQKbq4Rf3XKGq5tlGPSGwdneVI3HyYmIfo0D9MlS0UN8OfDRcBfofaS/eCd 9IWS8A5QPk9mwxg4UxD6X4FGnh0tVmnRkSakQBaeWLT6CP01J9FT5rQ3xA4mF4vV UWMUE7vA57sQUTy0o7F13UOQJTYM/Qw/Ua6z2XVUqkqnwNH4qHMgDw2pVZntZO8W SnIV1QHImG9NaZI9phOE+MDUAMtXVAu4zEE0fhfmYZkl47ONL4Up8z0w/B/PKc5w f7qjzTU4DuM2usLVsIgMxwHL448uRnj66OBKd0IpmbdYZty1g1U2TA== =285P -----END PGP SIGNATURE----- _______________________________________________ enigmail-users mailing list [email protected] https://admin.hostpoint.ch/mailman/listinfo/enigmail-users_enigmail.net
