-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello Patrick,
you're right about the rulesToObject and objectToRules functions. I'll move them into rules.jsm. Writing the rules file to disk in backupPrefs will result in two files. One with the saved Enigmail preferences and the pgpRules.xml. As I understand ticket #469 the use case for the save/restore function is to help users to install a certain configuration instead of guiding them through the advanced tab. Forcing the user to send and afterwards load two files makes the whole process error-prone. Regards Kai On 07/14/2015 05:36 PM, Patrick Brunschwig wrote: > On 14.07.2015 14:09, Kai Michaelis wrote: >> This patch extends the save/restore profile function so that it saves >> the contents of pgpRules.xml too. When restoring a saved profile all >> existing per-recipient rules are _deleted_ and replaced with the ones >> in the saved profile. > > Hi Kai > > From what I can see, you put a lot of logic into pref-enigmail.js that > should go into rules.jsm (or that actually is already there!). > > We should avoid to duplicate code. > > Why don't you simply write the rules file to disk, and and use the > existing EnigmailRules.loadRulesFile() to get them loaded? > > -Patrick > > > > _______________________________________________ > enigmail-users mailing list > [email protected] > To unsubscribe or make changes to your subscription click here: > https://admin.hostpoint.ch/mailman/listinfo/enigmail-users_enigmail.net > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVp4IaAAoJEGWsUE61CoxD1jUP/3eG7J4TtADau5HeKUJC3Vs3 4Kahx1kIWvTZ9iuMMa+z6Kg76PrZHAaa5p7vBIqCGTW9nEQTRnu/acVCHe2qU65g jMnZ9tUD/paO6L4voqV00VUKA+My/uM8q91MqH6+v//hmAsl8uQsP5pyY8E9NzTN iPPN6a/P1F+wgAGwlpL/c0faCiB6uBTwUMEVgybQI7pgsKPVflK5ra+y4+a/kxDn n0sfwOdNv1ilhI+32WKXOjUXnqKn99r8f4+8G4qUDOdCScOpib3sCCxvzyaIvY0s rXHo6M1D20ZWZlhZvPpFynIAg34NsDW9IHUWXjPQUNewqc9TCrOpRh8ENwyzBHXK wDy0gcjGjoWtG4bKALKMt4J+hTGAPNswvZeU2MoRYvv3m9EyfsPEAwcW9hAYifMB xIlgwTLFAXdaoLllOgabl47Dy6UYpKNbvoHlW1bXzQr3dc9sgG0g/RwpPxWOg0QU Nm7EQHai0XjbKbAfXlQ/tyizqEK19faZKuHyyM+oqpBEByFo0tC1oq9KvwaD4Ihy WYQNJgM6CA5Ux7oTZNPg96ng0XFdbSk7VCJGpGErtcAWqBNraEYoczII7ExIMgDQ v55eYNdp2r0A0ZvAlcdrJs25787Gd5+RQvV/CivoLfwmmS79F75Xtnzn6IPEP+JT IbuGABVADgg+nNmOLIKC =ishY -----END PGP SIGNATURE----- _______________________________________________ enigmail-users mailing list [email protected] To unsubscribe or make changes to your subscription click here: https://admin.hostpoint.ch/mailman/listinfo/enigmail-users_enigmail.net
