-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 > On 07/14/2015 05:36 PM, Patrick Brunschwig wrote: >> On 14.07.2015 14:09, Kai Michaelis wrote: >>> This patch extends the save/restore profile function so that it >>> saves the contents of pgpRules.xml too. When restoring a saved >>> profile all existing per-recipient rules are _deleted_ and >>> replaced with the ones in the saved profile. > >> Hi Kai > >> From what I can see, you put a lot of logic into pref-enigmail.js >> that should go into rules.jsm (or that actually is already >> there!). > >> We should avoid to duplicate code. > >> Why don't you simply write the rules file to disk, and and use >> the existing EnigmailRules.loadRulesFile() to get them loaded? >
On 16.07.15 12:06, Kai Michaelis wrote: > you're right about the rulesToObject and objectToRules functions. > I'll move them into rules.jsm. > > Writing the rules file to disk in backupPrefs will result in two > files. One with the saved Enigmail preferences and the > pgpRules.xml. As I understand ticket #469 the use case for the > save/restore function is to help users to install a certain > configuration instead of guiding them through the advanced tab. > Forcing the user to send and afterwards load two files makes the > whole process error-prone. Could we agree on bottom posting on this list? I fully agree with what you say. But when you restore the settings, you could save the new rules-file over the old one and then load the rules from that file. You would anywayOR you simply change EnigmailRules.loadRulesFile() to allow loading from the backup rules file. - -Patrick -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVp918AAoJENsRh7ndX2k7KQYQAI7lRcQtofQUwKKOKd+4gkrm 2I93RZilLJda1x21faF93erk6F6STuN05un14fBfyHz4xcLx9Ba92tCNClDWKmjf 0ZbhwJXLXfTiV+jD+m3xJ4Kpn2yAtGAuarCaZ7JVkCgts2U4evDC7mNLLAIi5B7E WGZslfGTDLJte1ISusPh8xK42lGDbJ/bEYfVQZzn7pQgnkgu3zZ+ps4nBwbDBJSa UC1M+zuSM8JV2Hb12kGf0gVcTH43yxolcb6ivL4U51Em+vb+nDbyK9dSsZZwMGcW ZkXShDk+FTrfg4yZaaUbUgO+vQ0xBh0hAaWFY0/zT97fboDAlgxuTYZvgT3Iaxr4 Cdjwa/ZWUwyhxFgbAscnXSaX3A+q5nvbNleyWnRq7h0fttUgDcbwFfQ+uE/WGV/i 2E5tI3pgkDyh467urEWDRvOG1itLt0BZ+TKRfnZVKafKl732mRxOZc/lF904PF6B bUs/itipNRWKralBmJyj8UvwaZ+dHAOGObTFjL98r9udAWEmsOOBQRUIjMxRJnmw ItAAGKW5svOeKn/AYOp48j15rbcLER2h1KlZ1Kq8OP3LxyEq4U23YJRnPP84gNgq dS1Npl2T2jkleMoH6UK4YkYletZdqXTrr4U3r4ra8Dks6OLesf+ImYBQYgVK0Fwh vGFRlv6aoAZPMkE5IsWP =yU28 -----END PGP SIGNATURE----- _______________________________________________ enigmail-users mailing list [email protected] To unsubscribe or make changes to your subscription click here: https://admin.hostpoint.ch/mailman/listinfo/enigmail-users_enigmail.net
