[EMAIL PROTECTED] wrote:
Enlightenment CVS committal

Author  : mandrake
Project : e16
Module  : e

Dir : e16/e/src


Modified Files:
E.h actions.c borders.c clone.c desktops.c dialog.c evhandlers.c focus.c fx.c handlers.c hints.c iconify.c ipc.c menus.c misc.c moveresize.c pager.c session.c settings.c sound.c stacking.c startup.c text.c timestamp.h ttfont.c warp.c x.c zoom.c



Log Message: Thu Mar 18 12:10:13 EST 2004 (Mandrake)

Fixed a boatload of warnings.  Commented out a couple of functions that
were no longer being used.  I fixed some of these warnings a few years ago
and somehow *ahem* they were put back in ;)

...
===================================================================
RCS file: /cvsroot/enlightenment/e16/e/src/actions.c,v
retrieving revision 1.145
retrieving revision 1.146
diff -u -3 -r1.145 -r1.146
--- actions.c 16 Mar 2004 22:10:06 -0000 1.145
+++ actions.c 18 Mar 2004 17:03:46 -0000 1.146
@@ -564,6 +564,8 @@
{
EDBUG(6, "doNothing");
EDBUG_RETURN(0);
+ ewin = NULL;
+ params = NULL;
}
static int

I have deliberately been taking out these things because I think they are silly :)

You are trying to avoid compiler warnings by introducing obviously silly
code doing nothing except *maybe* avoiding compiler warnings.

I assume that your compiler (or lint?) says something like "warning:
unused function argument".
Another compiler could with just as much reason complain about either
"useless assignment" or "unreachable code".

What you really want to do is something like use __attribute__
((unused)) but that's a gcc thing.
To my knowledge there is no good portable way to do this and therefore I
prefer to adjust my tools not to complain about unused function
arguments, when necessary. Recent gcc compilers don't issue this
warning, even with -Wall.

/Kim


------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click _______________________________________________ enlightenment-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to