* on [03.18.04] Kim Woelders <[EMAIL PROTECTED]> scribbled: > I'm not going to change my opinion for that reason. It is silly to put > in silly code. > I don't care too much either, if that the way "you" want it, fine. > The problem seems to me that there is no standard way to do this. > I like the USE_VAR macro better than the useless unreachable assignment, > though :)
Here's the rationale for having these assignments in the code. in many cases, the parameters are there because they are called from a generic function pointer or lookup table. Or, in some cases (like fnlib being now optional) they're there because it's used in some compile cases and not in others. When they're useless because you truly do not need them you should get rid of them. For that reason you should keep things like -W -Wall -Wmissing-prototypes -Wmissing-declarations enabled while developing code. When there is no way around keeping those function parameters in your code for reasons like mentioned above, you should certainly remove those warnings by inserting "silly code that is never executed" so that you can see when code is actually un-necessary, like the code that I commented out in several places. That is my 2c -- Geoff "Mandrake" Harrison President, CEO - Digital Environments, Inc. ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click _______________________________________________ enlightenment-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
