-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
If I understand entrance is lauched by another program (entranced?) that sets
DISPLAY. Correct ?
Thus testing DISPLAY should be a first step in main() checks. Ok. And storing a
strdup of getenv("DISPLAY") should be made earlier I think.
What do you think of my ecore_evas_engine_type_supported_get() call ?
IMHO testing include files is not correct in configure. I agree with Raster on
that point.
Another topic: how do you start another server on a machine that already have an
X running at :0.0 ? To test entrance I like to start another server with
xinit ${e17path}/sbin/entranced -- X :1
Do you have feedback on this ?
ps: I'll use diff -u, promiss!
Michel
Ibukun Olumuyiwa a �crit :
> Actually, if the DISPLAY variable is not set entrance doesn't even
> start, so it wouldn't even get this far (it would have failed at
> ecore_evas_software_x11_new()). So I'd say adding a fallback would be
> redundant at this point.
>
> And yes Michel, please next time send diffs using -u :)
>
> Corey Donohoe wrote:
> | We should have an else condition to the getenv check, if e->display is
> NULL
> | pam authentication is going to fail miserably. We also prefer 'diff -u'
> | format :D
> |
> | * Michel Briand ([EMAIL PROTECTED]) wrote:
> |
> |>-----BEGIN PGP SIGNED MESSAGE-----
> |>Hash: SHA1
> |>
> |>Hello Ibukun
> |>
> |>please chech these files:
> |>
> |> entrance_session.c: fix a segfault when DISPLAY=(null)
> |>
> |>Index: src/client/entrance_session.c
> |>===================================================================
> |>RCS file:
> /cvsroot/enlightenment/e17/apps/entrance/src/client/entrance_session.c,v
> |>retrieving revision 1.67
> |>diff -r1.67 entrance_session.c
> |>38c38
> |>< char *db;
> |>---
> |>
> |>> char *db, *str;
> |>
> |>49,51c49,51
> |>< if (!display)
> |>< e->display = strdup(getenv("DISPLAY"));
> |>< else
> |>---
> |>
> |>> if (!display) {
> |>> if ((str = getenv("DISPLAY"))) e->display = strdup(str);
> |>> } else
> |
> |
> | __
> | Corey Donohoe
> | http://www.atmos.org
> |
> |
> | -------------------------------------------------------
> | SF email is sponsored by - The IT Product Guide
> | Read honest & candid reviews on hundreds of IT Products from real users.
> | Discover which products truly live up to the hype. Start reading now.
> | http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> | _______________________________________________
> | enlightenment-devel mailing list
> | [email protected]
> | https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>
> --
>
> Ibukun Olumuyiwa
> http://xcomputerman.com
>
> "I will stand upon my watch, and set me upon the tower,
> and will watch to see what he will say unto me,
> and what I shall answer when I am reproved."
>
- -------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
iD8DBQFCMLurMSWL0LSvaHgRArniAKCjBgfMILmHlo3Q7UfU04r+vzTh8wCeLfKW
0q5qaOMoXAsLDo23Zd9pC0M=
=A8KA
-----END PGP SIGNATURE-----
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id396&op=click
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
