On Tue, 4 Jul 2006 06:55:47 +1000 David Seikel <[EMAIL PROTECTED]> babbled:
> On Mon, 3 Jul 2006 15:24:31 -0500 [EMAIL PROTECTED] wrote: > > > On Mon, Jul 03, 2006 at 03:15:49PM -0400, Christopher Michael wrote: > > > Carsten Haitzler (The Rasterman) wrote: > > > > On Mon, 3 Jul 2006 03:35:44 -0400 (EDT) Enlightenment CVS > > > > <[EMAIL PROTECTED]> babbled: > > > > > > > > What was the reasoning for this? why would one need to pass the > > > > path to an module icon explicitly? (if you want to do your own > > > > icon in a dialog for a different dialog you can always do the > > > > dialog by hand?) > > > > > > > > <-- snip --> > > > > > This was requested by Andy so that modules config dialogs could show > > > their icon in the border of their config dialogs. I think > > > consistency was his main goal and also so users can identify easily > > > what config dialog is for what module. > > > > > > If it is a problem I can roll it back and change the modules back to > > > previous way of showing the E icon on the border of the config > > > dialog. > > > > > > dh > > > > > > I *think* he meant that e already knows where the modules icon is, so > > you you shouldn't need to pass th path in. That is, it should just > > use the icon by default. > > For e_config_dialog_new(), the only thing that it has to go by (if the > path is not passed in) is the E_Container, which has an E_Gadman in it. > I'm unsure if that is enough, isn't gadman going away? I'm not seeing > any where in there that will point to where the icon is, it only seems > to be in the E_Module. How to get there from here? you don't :) you need to pass it in... :) > While on the same subject, I'm not so sure that a gadcon can get access > to its E_Module if all it has is the E_Gadcon or E_Gadcon_Client, or > E_Gadcon_Client_Class. This makes it hard to get access to its own > icon in gadcon callbacks that only get one of those gadcon structs. I > suggest that the E_Gadcon structs have the relevant E_Module stored in > them. it can't. gadcon isn't JUST for modules. its entirely separate from modules. the fact that the only user of gadcon is modules is a separate matter :) > On the other hand, I'm not sure of all the gory internal details of the > module implementation that is hidden from the average module writer. > All I just said could be complete bollocks. > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [EMAIL PROTECTED] 裸好多 Tokyo, Japan (東京 日本) Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
